splatink/lbmk
1
0
Fork 0
mirror of https://codeberg.org/libreboot/lbmk.git synced 2026-03-28 15:09:04 +02:00
Code Issues Packages Projects Releases Wiki Activity
599 Commits 22 Branches 45 Tags
2be1a8ea76cc33be4ec359155d2276046f1007a6
Commit Graph

262 Commits

Author SHA1 Message Date
Leah Rowe
2be1a8ea76 download/coreboot: fix error handling in subshell 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-24 07:45:07 +01:00
Leah Rowe
d0171eeff3 download/coreboot: don't needlessly re-download 2023-05-24 07:16:51 +01:00
Leah Rowe
c616930b71 download/coreboot: remove unnecessary bloat 
it is not necessary to have help output

similarly, listing all boards in this script is
pointless. why not just run ls -1 on the directory?
 2023-05-21 03:24:29 +01:00
Leah Rowe
d1935c0590 build/clean/u-boot: remove unnecesssary check 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 21:48:12 +01:00
Leah Rowe
676efbb0df build/clean/u-boot: improved coding style 
tabs for indentation

simplify some checks
 2023-05-20 21:47:10 +01:00
Leah Rowe
06a92f61a8 build/clean/ich9utils: don't use subshell 
this also fixes error handling

Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 21:38:54 +01:00
Leah Rowe
43e2dfe2bf build/u-boot: top-down, split-function code style 
main() on top

top-down order of logic

logic split into separate functions

Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 21:33:37 +01:00
Leah Rowe
a8f0721a6f build/payload/u-boot: 79 chars or less per line 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 20:48:19 +01:00
Leah Rowe
89ac1ea5a9 build/payload/u-boot: fix wrong attributions 
only alper and ferass have ownership of this file,
but ferass only submitted to it in 2022, not 2021

fix this

i've removed myself from the file, for now

i never touched this file before, so it's
not right that my name be here

put alper's name at the top, because alper
was the person who created this file first

Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 20:32:40 +01:00
Leah Rowe
c973b95909 build/payload/grub: rename functions for clarity 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 20:16:10 +01:00
Leah Rowe
51e0e40123 build/payload/grub: remove unnecessary check 
sed does the same job as cp, in this situation

Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 20:08:40 +01:00
Leah Rowe
8e206be7c8 build/payload/grub: split logic into functions 
main() on top

top-down logic

Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 20:07:22 +01:00
Leah Rowe
db7e81612a build/payload/grub: 79 chars or less per line 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 19:55:40 +01:00
Leah Rowe
92bd18c45a build/release/roms: minor cleanup 
split actual purging of blobs to a function

rename functions for clarity
 2023-05-20 19:45:08 +01:00
Leah Rowe
ec3d1006b3 build/release/roms: handle argument properly 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 19:40:31 +01:00
Leah Rowe
e0b9766087 build/release/roms: remove superfluous comments 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 19:36:51 +01:00
Leah Rowe
681538a20c build/release/roms: handle errors inside subshell 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 19:35:36 +01:00
Leah Rowe
a9bd54423c build/release/roms: split logic into functions 
main() on top

top-down logic

79 chars or less, per line

Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 19:33:29 +01:00
Leah Rowe
2983309006 build/release/roms: use tabs for indentation 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 19:15:50 +01:00
Leah Rowe
fff5fa53ff build/release/src: 79 chars or less per code line 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 19:03:04 +01:00
Leah Rowe
1cdf1c7cf0 build/release/src: handle errors in subshells 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 18:59:59 +01:00
Leah Rowe
16f878e882 build/release/src: split logic into functions 
main() on top

top-down logic

Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 18:52:33 +01:00
Leah Rowe
4e2ee58ac5 build/ich9utils: simplify, fix error handling 
errors weren't being handled inside a subshell

Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 18:32:52 +01:00
Leah Rowe
93ec91e862 build/memtest86plus: use tabs for indentation 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 18:28:58 +01:00
Leah Rowe
4b80f250fb build/clean/crossgcc: better code style 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 18:28:17 +01:00
Leah Rowe
187d5fa418 build/descriptors: simplify and fix error handling 
main() on top

some parts of the script weren't erroring properly

Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 18:26:09 +01:00
Leah Rowe
a05be16998 build/grub: fix inconsistent indentation 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 18:13:44 +01:00
Leah Rowe
02919c47ce build/grub: implement error handling 
it uses a subshell, so errors weren't observed

Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 18:10:41 +01:00
Leah Rowe
5bab3bbc33 build/grub: introduce main(), split it up 
easier to read

Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 18:06:15 +01:00
Leah Rowe
277e1df0af build/cbutils: remove unnecessary directory check 
it will already fail if the coreboot download did.

if the coreboot download succeeds, the directory exists.

Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 18:01:02 +01:00
Leah Rowe
ed9eb4624c build/cbutils: rename function for clarity 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 18:00:31 +01:00
Leah Rowe
b12dced470 build/cbutil: avoid frivilous use of subshells 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 17:57:15 +01:00
Leah Rowe
355a45b435 build/cbutils: top-down coding style, main on top 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 17:53:03 +01:00
Leah Rowe
9f58d4e481 build/cbutils: 79 chars or less per line 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 16:13:02 +01:00
Leah Rowe
691f266441 build/cbutils: use tabs for indendation 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-20 16:12:25 +01:00
Leah Rowe
08ad9eb15f download/coreboot: minor cleanup 2023-05-18 12:37:55 +01:00
Leah Rowe
4ac0bc8d3e blobutil/download: minor code cleanup 
Signed-off-by: Leah Rowe <leah@libreboot.org>
 2023-05-18 11:41:56 +01:00
Leah Rowe
52d87f5f08 download/coreboot: minor code cleanup 
i'm pretty much finished now

there might be a few more changes later,
like stricter error handling, more verbose
error messages, etc

right now, it relies on -e to kill lbmk
on error, and uses the exit command

another planned change it to support
other upstreams besides coreboot.org,
such as the dasharo codebase

the latter is *why* i refactored this
download script, for asus kgped-d16
 2023-05-15 05:01:48 +01:00
Leah Rowe
7bd206b9e7 download/coreboot: remove errant code 
the build_error file is obsolete
 2023-05-15 04:53:14 +01:00
Leah Rowe
bd82d90faf download/coreboot: tidy up variable names 2023-05-15 04:44:47 +01:00
Leah Rowe
66d06afd6c download/coreboot: run extra.sh from cbtree 
to my knowledge, this feature has never been used,
but lbmk permits resources/coreboot/boardname/extra.sh
to execute, as provided by the maintainer, with working
directory set to: coreboot/boardname

this could be used to extend lbmk in a number of ways

for example, it could be used to patch 3rdparty/

it could also be used to break coreboot in creative
and novel ways. hint hint.
 2023-05-15 04:17:50 +01:00
Leah Rowe
c4b0825c5e download/coreboot: avoid variable conflict 
the "board" variable in prepare_new_coreboot_tree()
is also declared in fetch_coreboot_trees

for the one in prepare_new_coreboot_tree, it's passed
as an argument to the function, so give it a new name

i learned that some shells have a global scope, when
using variables of the same name between functions
 2023-05-15 04:14:50 +01:00
Leah Rowe
0e1e9c1773 download/coreboot: fix downloads without argument 
this should download all trees:

	./download coreboot

without this patch, it doesn't

with this patch, it works

i overlooked this during earlier
refactoring. auditing revealed it.
 2023-05-15 04:11:10 +01:00
Leah Rowe
bea6735395 download/coreboot: much cleaner coding style 
top-down order, and *still* rfc 3676 compliant

i finished simplifying the logic, and
i split everything into smaller functions

there is still more more polishing to do

final touches will be done in new revisions
 2023-05-15 04:05:27 +01:00
Leah Rowe
2d69072a09 download/coreboot: clone upstream via ./gitclone 
coreboot trees/patching is still handled
specifically by "./download coreboot"

command now available in lbmk:

./gitclone coreboot

this *only* creates the directory at:
coreboot/coreboot

this directory is never used in builds.
it is only used by download/coreboot to
create patched trees for each mainboard
 2023-05-15 03:24:19 +01:00
Leah Rowe
c17423e475 download/coreboot: simplify check 2023-05-15 02:51:15 +01:00
Leah Rowe
00cafd7022 download/coreboot: fix misnamed function 2023-05-15 02:39:29 +01:00
Leah Rowe
86512e84be download/coreboot: simplify small if statements 2023-05-15 02:38:22 +01:00
Leah Rowe
d28584f3d0 download/coreboot: fetch config in new function 2023-05-15 02:30:14 +01:00
Leah Rowe
162f4bf5dd download/coreboot: use global variables 
i'm going to move the config recursion check
into a separate function, and global variables
make it easier to handle
 2023-05-15 02:17:39 +01:00