splatink/lbmk
1
0
Fork 0
mirror of https://codeberg.org/libreboot/lbmk.git synced 2026-03-25 13:29:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

util/nvmutil: rw file: guard rc before addition

Browse Source 
otherwise, it could still overflow

Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
Leah Rowe
2026-03-14 22:43:22 +00:00
parent 93603e1572
commit ef4e9dc895
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
util/nvmutil/nvmutil.c
View File

@@ -1882,6 +1882,10 @@ rw_file_exact(int fd, u8 *mem, size_t nrw,
size_t retries_on_zero = 0;
while (1) {
/* Prevent theoretical overflow */
if ((size_t)rv > (nrw - rc))
goto err_rw_file_exact;
rc += rv;
if ((size_t)rc >= nrw)
@@ -1896,10 +1900,6 @@ rw_file_exact(int fd, u8 *mem, size_t nrw,
if (rv < 0)
return -1;
/* Prevent theoretical overflow */
if ((size_t)rv > (nrw - rc))
goto err_rw_file_exact;
if (rv == 0) {
if (retries_on_zero++ < max_retries)