splatink/lbmk
1
0
Fork 0
mirror of https://codeberg.org/libreboot/lbmk.git synced 2026-03-25 13:29:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

util/nvmutil: prevent underflow in comparison

Browse Source 
we already check before that rv is not negative,
and it starts at zero, but it's good to guard
it here just in case (for future re-factoring).

if rv is negative, it could convert (casted to
size_t) to a huge number (we don't want that).

Signed-off-by: Leah Rowe <leah@libreboot.org>
This commit is contained in:
Leah Rowe
2026-03-15 01:06:36 +00:00
parent 7bd1e551d8
commit f509c87d04
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
util/nvmutil/nvmutil.c
View File

@@ -1908,7 +1908,7 @@ rw_file_exact(int fd, u8 *mem, size_t nrw,
while (1) {
/* Prevent theoretical overflow */
if ((size_t)rv > (nrw - rc))
if (rv >= 0 && (size_t)rv > (nrw - rc))
goto err_rw_file_exact;
rc += rv;